Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • S Solaar
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 10
    • Issues 10
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 2
    • Merge requests 2
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • pwr-Solaar
  • Solaar
  • Merge requests
  • !37

Py3 compat: replace use of "unicode" (pwr/Solaar#32)

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Administrator requested to merge github/fork/Lekensteyn/py3-compat into master May 03, 2013
  • Overview 1
  • Commits 1
  • Pipelines 0
  • Changes 1

Created by: Lekensteyn

Generating "an unknown notification" type bailed out because of an unknown feature type None. Since isinstance(other, str) is False for None, the script will raise an exception on isinstance(other, unicode).

There is no differentiation between str and bytes in Python 2, therefore add another condition to NamedInt.__eq__ to catch unknown types (like bytes).

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: github/fork/Lekensteyn/py3-compat