Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • S Solaar
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 10
    • Issues 10
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 2
    • Merge requests 2
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • pwr-Solaar
  • Solaar
  • Merge requests
  • !646

better handling of DJ notifications and reports; don't halt on unexpected report IDs or lengths

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Peter F. Patel-Schneider requested to merge github/fork/pfps/notify into master Jan 18, 2020
  • Overview 41
  • Commits 3
  • Pipelines 0
  • Changes 2

Solaar creates notifications for DJ reports, e.g., mouse movement and keystrokes.
Solaar treats DJ notifications as HID++ 1.0 notifications resulting in warnings and errors.

This PR does not create notifications for DJ mouse movement and keystroke reports. This PR segregates DJ notifications into their own handler, which currently ignores them all as the events that might cause changes have HID++ 1.0 notifications as well.

Instead of halting Solaar when a message with unexpected report id or size is found, log a waning and ignore the message. This was tested by removing information on one of the expected report ids and size - Solaar correctly handled the now-unexpected messages.

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: github/fork/pfps/notify