Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • S Solaar
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 10
    • Issues 10
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 2
    • Merge requests 2
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • pwr-Solaar
  • Solaar
  • Merge requests
  • !732

install: fix up errors when required packages not installed

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Peter F. Patel-Schneider requested to merge github/fork/pfps/require into master Apr 05, 2020
  • Overview 2
  • Commits 1
  • Pipelines 0
  • Changes 2

The code had a require_version for Gtk 3.0 before the call to the _require function that caught the exception. This change moves that check into the _require function so that the error message is printed instead of dumping core.

Fixes #462 (closed)

I checked the code by setting up a Fedora container and running solaar from within the container with several variations of packages installed.

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: github/fork/pfps/require