Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • S Solaar
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 10
    • Issues 10
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 2
    • Merge requests 2
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • pwr-Solaar
  • Solaar
  • Merge requests
  • !926

receiver: simplify settings interface

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Peter F. Patel-Schneider requested to merge github/fork/pfps/set into master Aug 22, 2020
  • Overview 3
  • Commits 1
  • Pipelines 0
  • Changes 3

The number of arguments to the settings templates convenience functions was growing so large that calls to them had their arguments one per line, making them harder to read; the conveniene functions were growing large; and adding a new argument required changes to multiple convenience functions. This PR eliminates the convenience functions and also simplifies the settings classes. The net result is that settings templates are shorter (because the label and description arguments are no longer needed) but perhaps slightly more complex (because a simple setting template needs to set up the three classes directly). Splitting the arguments into three groups does make the setting templates easier to understand, though.

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: github/fork/pfps/set