Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • S Solaar
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 10
    • Issues 10
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 2
    • Merge requests 2
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • pwr-Solaar
  • Solaar
  • Merge requests
  • !936

Support for GESTURE_2 settings

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Administrator requested to merge github/fork/viniciusbm/gestures2_impl1 into master Aug 30, 2020
  • Overview 2
  • Commits 16
  • Pipelines 0
  • Changes 10

Created by: viniciusbm

Closes #411 (closed). Closes #788.

This is a follow-up to #934 and #788.

I didn't use the set and get methods directly from Gesture because I tried to avoid unnecessary requests, which is possible because we can read and write options that share an offset in a single request.

@pfps, thank you for writing the code of #934 (upon which this PR is based). I retained your old commit, as I didn't know a good way to replace it with your updates after I made a lot of changes.

So far, I've only implemented the boolean settings. I tried to make the UI look better than that ugly hack I had written (#818), but it still has some alignment issues. The UI changes also apply to KEYBOARD_DISABLE_KEYS.

Of course, corrections and ideas are welcome.

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: github/fork/viniciusbm/gestures2_impl1