Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • S Solaar
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 10
    • Issues 10
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 2
    • Merge requests 2
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • pwr-Solaar
  • Solaar
  • Merge requests
  • !998

GUI for changing Notification Rules

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Administrator requested to merge github/fork/viniciusbm/diversion_mouseclick_and_ui into master Nov 14, 2020
  • Overview 2
  • Commits 19
  • Pipelines 0
  • Changes 3

Created by: viniciusbm

See discussion in #988.

This PR adds a GUI to display, create and edit diversion rules. It still needs to be improved in many ways, but it's already functional. It displays built-in rules (read-only) and rules defined by the user (which are editable). To see the available options, right-click a row. To edit the contents of a row, click it and change the values on the bottom panel. For types that require a string from a list, suggestions are shown under the text field in a case-insensitive way, ignoring underscores and spaces, considering any allowed value that contains the input text as a substring at any position (e.g. for KeyPress, typing "volume" shows the suggestions XF86_AudioLowerVolume and XF86_AudioRaiseVolume).

TESTING SUGGESTIONS:
Before testing, read docs/rules.md so that you understand something about what these rules do in Solaar. Create the file ~/.config/solaar/rules.yaml with a few rules. There are some sample rules at the end of docs/rules.md Then click on the button for editing rules. Check that all your rules show up and that the built-in rules also show up. Report on any problems. Then try to edit some rules. Do some easy changes, like changing a KeyPress or MouseScroll action or a Test condition. Do some structural changes, like adding a condition to a rule or adding an entirely new rule. Check that these rules are saved correctly. Report on any problems. Suggestions for UI changes are welcome. Changes that are hard to implement will likely be deferred to some indefinite future.

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: github/fork/viniciusbm/diversion_mouseclick_and_ui