Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • Q quickfix
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 48
    • Issues 48
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 25
    • Merge requests 25
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • quickfixgo
  • quickfix
  • Issues
  • #524
Closed
Open
Issue created Nov 22, 2022 by shipa988@shipa988Contributor

deadlock when disconnecting dynamic session

this kind of writing in channel makes deadlock possibility! https://github.com/quickfixgo/quickfix/blob/7945e4b53d7be2e68202fe68952ee31f2a736ccc/session.go#L742

Possible deadlock occurs in dynamic session closing because line https://github.com/quickfixgo/quickfix/blob/7945e4b53d7be2e68202fe68952ee31f2a736ccc/session.go#L768

is the only reader from channel s.sessionEvent, and after ending of loop https://github.com/quickfixgo/quickfix/blob/7945e4b53d7be2e68202fe68952ee31f2a736ccc/session.go#L752 no one can read from channel s.sessionEvent

PR #523

Thanks!

Assignee
Assign to
Time tracking