Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • Q quickfix
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 48
    • Issues 48
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 25
    • Merge requests 25
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • quickfixgo
  • quickfix
  • Merge requests
  • !145

Misc field type refactoring

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Administrator requested to merge github/fork/cbusbey/type_refactor into master Jun 04, 2016
  • Overview 1
  • Commits 2
  • Pipelines 0
  • Changes 18

Created by: cbusbey

  • Removes some archaic field constructors

eg,

f := quickfix.NewFIXString("hello")

NewFIXString and the other field constructors returned a pointer to the initialized field. In practice, this isn't normally necessary. A reference to a FIX field is only necessary when reading a field into a zero-valued field.

  • Adds helper convertors to field types
var cs field.CollStatus
msg.Body.Get(&cs)

//Instead of...
val := int(cs.FIXInt)

//do
val = cs.Int()
  • Embeds time.Time in FIXUTCTimestamp. This was previously an unembedded field Value. Embedding has the benefit of calling time.Time methods directly on UTCTimestamp fields. Note that this change required regenerated fields, c0d827ee
Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: github/fork/cbusbey/type_refactor