Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • Q quickfix
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 48
    • Issues 48
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 25
    • Merge requests 25
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • quickfixgo
  • quickfix
  • Merge requests
  • !160

Proper FIX logout sequence

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Administrator requested to merge github/fork/bhaan/logout-process into master Jun 30, 2016
  • Overview 4
  • Commits 2
  • Pipelines 0
  • Changes 3

Created by: bhaan

Changes proposed in this pull request:

  • Updates acceptor/initiator stop sequence. Sends a Logout and waits for a response before invoking the application OnLogout callback, per FIX standard
  • Removes redundant calls to the application OnLogout callback. Currently, the run() function in session ultimately invokes OnLogout when it returns, while the inSession state has a few cases where it invokes the callback as well.
  • Improves the event log output for the logon and logout sequences. Following the QuickFIX/C++ implementation, a proper session event sequence will look like the following:
Initiator
2016/06/30 15:31:45.167656 Sending logon request
2016/06/30 15:31:45.185684 Received logon response
2016/06/30 15:31:49.810696 Inititated logout request
2016/06/30 15:31:49.825808 Received logout response
2016/06/30 15:31:49.825833 Disconnected
Acceptor
2016/06/30 15:31:45.170768 Received logon request
2016/06/30 15:31:45.182621 Responding to logon request
2016/06/30 15:31:49.814847 Received logout request
2016/06/30 15:31:49.815776 Sending logout response
2016/06/30 15:31:49.827149 Disconnected
Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: github/fork/bhaan/logout-process