Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • Q quickfix
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 48
    • Issues 48
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 25
    • Merge requests 25
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • quickfixgo
  • quickfix
  • Merge requests
  • !167

Handle OnLogon/Logout callbacks in user space

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Administrator requested to merge github/fork/bhaan/session-msg-handling into master Jul 13, 2016
  • Overview 1
  • Commits 1
  • Pipelines 0
  • Changes 1

Created by: bhaan

Another follow up to #164

Calls to SendToTarget within the OnLogon callback will currently deadlock. This fix will kick that callback on a dedicated goroutine.

I did the same for OnLogout. Although that wont cause a deadlock on SendToTarget, there could be unknown side effects if an application fails to return from OnLogout, ultimately preventing the session from terminating

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: github/fork/bhaan/session-msg-handling