Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • Q quickfix
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 48
    • Issues 48
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 25
    • Merge requests 25
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • quickfixgo
  • quickfix
  • Merge requests
  • !171

Reset peer timer after logon

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Administrator requested to merge github/fork/bhaan/peer-timer into master Jul 15, 2016
  • Overview 1
  • Commits 1
  • Pipelines 0
  • Changes 2

Created by: bhaan

We were seeing a test request (35=1) being sent immediately after logon for our acceptor. After looking into this, it appears that the peerTimer was being reset before having processed the logon request form the initiator. Because the initiator's logon contains the heartbeat interval, the acceptor was trying to reset the timer with a zero value, ultimately causing the peer timer to activate immediately.

The following changes will prevent timers from being reset with a zero value, and ensures that the timer is reset once the logon (and heartbeat interval) is received.

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: github/fork/bhaan/peer-timer