Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • Q quickfix
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 48
    • Issues 48
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 25
    • Merge requests 25
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • quickfixgo
  • quickfix
  • Merge requests
  • !172

Initiate logout for all logged on states

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Administrator requested to merge github/fork/bhaan/acceptor-logout into master Jul 15, 2016
  • Overview 1
  • Commits 1
  • Pipelines 0
  • Changes 2

Created by: bhaan

fixes #170 (closed) related to #171

The logout sequence has stopped working due to the logout initiation being coupled to the inSession state. As identified in #171, we were seeing the session immediately sending a test request after logon. By doing so, the session state transitioned from inSession to pendingTimeout. While the pendingTimeout state embeds the inSession state, the call to application.Stop only checks if the current state is the inSession state to initiate the logout sequence.

These changes move initiateLogout into the session, so the action on Stop can check IsLoggedOn, and initiate the logout sequence as necessary. Therefore all states that confirm true for the IsLoggedOn function interface, will result in a proper logout sequence.

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: github/fork/bhaan/acceptor-logout