Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • Q quickfix
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 48
    • Issues 48
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 25
    • Merge requests 25
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • quickfixgo
  • quickfix
  • Merge requests
  • !179

Conditionally increment target seq num on resend request

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Administrator requested to merge github/fork/bhaan/resend-request-target-seq-num into master Jul 27, 2016
  • Overview 1
  • Commits 1
  • Pipelines 0
  • Changes 1

Created by: bhaan

fixes #169 (closed)

The cause of the referenced issue was due to the target seq num being incremented while both sides were sending the resend request. Therefore when they received the corresponding sequence reset, the sequence of that message was lower than what was erroneously expected. Looking at the quickfix/c++ code, there is in fact a check to prevent this from happening:

https://github.com/quickfix/quickfix/blob/6bc717f88f8e8c3729415a0ec65ec2615d501728/src/C%2B%2B/Session.cpp#L448-L449

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: github/fork/bhaan/resend-request-target-seq-num