Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • Q quickfix
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 48
    • Issues 48
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 25
    • Merge requests 25
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • quickfixgo
  • quickfix
  • Merge requests
  • !315

Fix a data race condition in the memoryStore

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Administrator requested to merge github/fork/svanharmelen/b-data-race into master Jan 03, 2018
  • Overview 4
  • Commits 1
  • Pipelines 0
  • Changes 1

Created by: svanharmelen

@cbusbey I already got it back again... See the output below:

==================
WARNING: DATA RACE
Read at 0x00c42019ea28 by main goroutine:
  github.com/svanharmelen/xtdr/vendor/github.com/quickfixgo/quickfix.(*memoryStore).NextSenderMsgSeqNum()
      <autogenerated>:1 +0x53
  github.com/svanharmelen/xtdr/vendor/github.com/quickfixgo/quickfix.(*session).prepMessageForSend()
      /Users/svanharmelen/Documents/GoCode/src/github.com/svanharmelen/xtdr/vendor/github.com/quickfixgo/quickfix/session.go:279 +0x9a
  github.com/svanharmelen/xtdr/vendor/github.com/quickfixgo/quickfix.(*session).queueForSend()
      /Users/svanharmelen/Documents/GoCode/src/github.com/svanharmelen/xtdr/vendor/github.com/quickfixgo/quickfix/session.go:204 +0xcd
  github.com/svanharmelen/xtdr/vendor/github.com/quickfixgo/quickfix.SendToTarget()
      /Users/svanharmelen/Documents/GoCode/src/github.com/svanharmelen/xtdr/vendor/github.com/quickfixgo/quickfix/registry.go:50 +0xb3
  main.(*Router).sendRequests()
      /Users/svanharmelen/Documents/GoCode/src/github.com/svanharmelen/xtdr/cmd/marketdata/router.go:113 +0x4b1
  main.(*Router).Unsubscribe()
      /Users/svanharmelen/Documents/GoCode/src/github.com/svanharmelen/xtdr/cmd/marketdata/router.go:78 +0x5b
  main.(*Router).Stop()
      /Users/svanharmelen/Documents/GoCode/src/github.com/svanharmelen/xtdr/cmd/marketdata/router.go:63 +0xc7
  main.runMarketDataCommand()
      /Users/svanharmelen/Documents/GoCode/src/github.com/svanharmelen/xtdr/cmd/marketdata/main.go:127 +0x2b5
  main.NewMarketDataCommand.func1()
      /Users/svanharmelen/Documents/GoCode/src/github.com/svanharmelen/xtdr/cmd/marketdata/main.go:62 +0x33
  github.com/svanharmelen/xtdr/vendor/github.com/spf13/cobra.(*Command).execute()
      /Users/svanharmelen/Documents/GoCode/src/github.com/svanharmelen/xtdr/vendor/github.com/spf13/cobra/command.go:750 +0x886
  github.com/svanharmelen/xtdr/vendor/github.com/spf13/cobra.(*Command).ExecuteC()
      /Users/svanharmelen/Documents/GoCode/src/github.com/svanharmelen/xtdr/vendor/github.com/spf13/cobra/command.go:831 +0x444
  github.com/svanharmelen/xtdr/vendor/github.com/spf13/cobra.(*Command).Execute()
      /Users/svanharmelen/Documents/GoCode/src/github.com/svanharmelen/xtdr/vendor/github.com/spf13/cobra/command.go:784 +0x38
  main.main()
      /Users/svanharmelen/Documents/GoCode/src/github.com/svanharmelen/xtdr/cmd/marketdata/main.go:50 +0x34

Previous write at 0x00c42019ea28 by goroutine 9:
  github.com/svanharmelen/xtdr/vendor/github.com/quickfixgo/quickfix.(*memoryStore).IncrNextTargetMsgSeqNum()
      /Users/svanharmelen/Documents/GoCode/src/github.com/svanharmelen/xtdr/vendor/github.com/quickfixgo/quickfix/store.go:52 +0x64
  github.com/svanharmelen/xtdr/vendor/github.com/quickfixgo/quickfix.inSession.FixMsgIn()
      /Users/svanharmelen/Documents/GoCode/src/github.com/svanharmelen/xtdr/vendor/github.com/quickfixgo/quickfix/in_session.go:44 +0x43d
  github.com/svanharmelen/xtdr/vendor/github.com/quickfixgo/quickfix.(*inSession).FixMsgIn()
      <autogenerated>:1 +0x76
  github.com/svanharmelen/xtdr/vendor/github.com/quickfixgo/quickfix.(*stateMachine).fixMsgIn()
      /Users/svanharmelen/Documents/GoCode/src/github.com/svanharmelen/xtdr/vendor/github.com/quickfixgo/quickfix/session_state.go:87 +0x69
  github.com/svanharmelen/xtdr/vendor/github.com/quickfixgo/quickfix.(*stateMachine).Incoming()
      /Users/svanharmelen/Documents/GoCode/src/github.com/svanharmelen/xtdr/vendor/github.com/quickfixgo/quickfix/session_state.go:77 +0x4fe
  github.com/svanharmelen/xtdr/vendor/github.com/quickfixgo/quickfix.(*session).run()
      /Users/svanharmelen/Documents/GoCode/src/github.com/svanharmelen/xtdr/vendor/github.com/quickfixgo/quickfix/session.go:751 +0x567
  github.com/svanharmelen/xtdr/vendor/github.com/quickfixgo/quickfix.(*Initiator).handleConnection.func1()
      /Users/svanharmelen/Documents/GoCode/src/github.com/svanharmelen/xtdr/vendor/github.com/quickfixgo/quickfix/initiator.go:114 +0x38

Goroutine 9 (running) created at:
  github.com/svanharmelen/xtdr/vendor/github.com/quickfixgo/quickfix.(*Initiator).handleConnection()
      /Users/svanharmelen/Documents/GoCode/src/github.com/svanharmelen/xtdr/vendor/github.com/quickfixgo/quickfix/initiator.go:113 +0xcf
  github.com/svanharmelen/xtdr/vendor/github.com/quickfixgo/quickfix.(*Initiator).Start.func1()
      /Users/svanharmelen/Documents/GoCode/src/github.com/svanharmelen/xtdr/vendor/github.com/quickfixgo/quickfix/initiator.go:38 +0xe0
==================
==================
WARNING: DATA RACE
Write at 0x00c42019ea20 by main goroutine:
  github.com/svanharmelen/xtdr/vendor/github.com/quickfixgo/quickfix.(*memoryStore).IncrNextSenderMsgSeqNum()
      /Users/svanharmelen/Documents/GoCode/src/github.com/svanharmelen/xtdr/vendor/github.com/quickfixgo/quickfix/store.go:47 +0x54
  github.com/svanharmelen/xtdr/vendor/github.com/quickfixgo/quickfix.(*session).persist()
      /Users/svanharmelen/Documents/GoCode/src/github.com/svanharmelen/xtdr/vendor/github.com/quickfixgo/quickfix/session.go:328 +0x75
  github.com/svanharmelen/xtdr/vendor/github.com/quickfixgo/quickfix.(*session).prepMessageForSend()
      /Users/svanharmelen/Documents/GoCode/src/github.com/svanharmelen/xtdr/vendor/github.com/quickfixgo/quickfix/session.go:316 +0x363
  github.com/svanharmelen/xtdr/vendor/github.com/quickfixgo/quickfix.(*session).queueForSend()
      /Users/svanharmelen/Documents/GoCode/src/github.com/svanharmelen/xtdr/vendor/github.com/quickfixgo/quickfix/session.go:204 +0xcd
  github.com/svanharmelen/xtdr/vendor/github.com/quickfixgo/quickfix.SendToTarget()
      /Users/svanharmelen/Documents/GoCode/src/github.com/svanharmelen/xtdr/vendor/github.com/quickfixgo/quickfix/registry.go:50 +0xb3
  main.(*Router).sendRequests()
      /Users/svanharmelen/Documents/GoCode/src/github.com/svanharmelen/xtdr/cmd/marketdata/router.go:113 +0x4b1
  main.(*Router).Unsubscribe()
      /Users/svanharmelen/Documents/GoCode/src/github.com/svanharmelen/xtdr/cmd/marketdata/router.go:78 +0x5b
  main.(*Router).Stop()
      /Users/svanharmelen/Documents/GoCode/src/github.com/svanharmelen/xtdr/cmd/marketdata/router.go:63 +0xc7
  main.runMarketDataCommand()
      /Users/svanharmelen/Documents/GoCode/src/github.com/svanharmelen/xtdr/cmd/marketdata/main.go:127 +0x2b5
  main.NewMarketDataCommand.func1()
      /Users/svanharmelen/Documents/GoCode/src/github.com/svanharmelen/xtdr/cmd/marketdata/main.go:62 +0x33
  github.com/svanharmelen/xtdr/vendor/github.com/spf13/cobra.(*Command).execute()
      /Users/svanharmelen/Documents/GoCode/src/github.com/svanharmelen/xtdr/vendor/github.com/spf13/cobra/command.go:750 +0x886
  github.com/svanharmelen/xtdr/vendor/github.com/spf13/cobra.(*Command).ExecuteC()
      /Users/svanharmelen/Documents/GoCode/src/github.com/svanharmelen/xtdr/vendor/github.com/spf13/cobra/command.go:831 +0x444
  github.com/svanharmelen/xtdr/vendor/github.com/spf13/cobra.(*Command).Execute()
      /Users/svanharmelen/Documents/GoCode/src/github.com/svanharmelen/xtdr/vendor/github.com/spf13/cobra/command.go:784 +0x38
  main.main()
      /Users/svanharmelen/Documents/GoCode/src/github.com/svanharmelen/xtdr/cmd/marketdata/main.go:50 +0x34

Previous read at 0x00c42019ea20 by goroutine 9:
  github.com/svanharmelen/xtdr/vendor/github.com/quickfixgo/quickfix.(*memoryStore).NextTargetMsgSeqNum()
      <autogenerated>:1 +0x53
  github.com/svanharmelen/xtdr/vendor/github.com/quickfixgo/quickfix.(*session).checkTargetTooLow()
      /Users/svanharmelen/Documents/GoCode/src/github.com/svanharmelen/xtdr/vendor/github.com/quickfixgo/quickfix/session.go:540 +0x170
  github.com/svanharmelen/xtdr/vendor/github.com/quickfixgo/quickfix.(*session).verifySelect()
      /Users/svanharmelen/Documents/GoCode/src/github.com/svanharmelen/xtdr/vendor/github.com/quickfixgo/quickfix/session.go:497 +0x2a9
  github.com/svanharmelen/xtdr/vendor/github.com/quickfixgo/quickfix.(*session).verify()
      /Users/svanharmelen/Documents/GoCode/src/github.com/svanharmelen/xtdr/vendor/github.com/quickfixgo/quickfix/session.go:472 +0x49
  github.com/svanharmelen/xtdr/vendor/github.com/quickfixgo/quickfix.inSession.FixMsgIn()
      /Users/svanharmelen/Documents/GoCode/src/github.com/svanharmelen/xtdr/vendor/github.com/quickfixgo/quickfix/in_session.go:39 +0x402
  github.com/svanharmelen/xtdr/vendor/github.com/quickfixgo/quickfix.(*inSession).FixMsgIn()
      <autogenerated>:1 +0x76
  github.com/svanharmelen/xtdr/vendor/github.com/quickfixgo/quickfix.(*stateMachine).fixMsgIn()
      /Users/svanharmelen/Documents/GoCode/src/github.com/svanharmelen/xtdr/vendor/github.com/quickfixgo/quickfix/session_state.go:87 +0x69
  github.com/svanharmelen/xtdr/vendor/github.com/quickfixgo/quickfix.(*stateMachine).Incoming()
      /Users/svanharmelen/Documents/GoCode/src/github.com/svanharmelen/xtdr/vendor/github.com/quickfixgo/quickfix/session_state.go:77 +0x4fe
  github.com/svanharmelen/xtdr/vendor/github.com/quickfixgo/quickfix.(*session).run()
      /Users/svanharmelen/Documents/GoCode/src/github.com/svanharmelen/xtdr/vendor/github.com/quickfixgo/quickfix/session.go:751 +0x567
  github.com/svanharmelen/xtdr/vendor/github.com/quickfixgo/quickfix.(*Initiator).handleConnection.func1()
      /Users/svanharmelen/Documents/GoCode/src/github.com/svanharmelen/xtdr/vendor/github.com/quickfixgo/quickfix/initiator.go:114 +0x38

Goroutine 9 (running) created at:
  github.com/svanharmelen/xtdr/vendor/github.com/quickfixgo/quickfix.(*Initiator).handleConnection()
      /Users/svanharmelen/Documents/GoCode/src/github.com/svanharmelen/xtdr/vendor/github.com/quickfixgo/quickfix/initiator.go:113 +0xcf
  github.com/svanharmelen/xtdr/vendor/github.com/quickfixgo/quickfix.(*Initiator).Start.func1()
      /Users/svanharmelen/Documents/GoCode/src/github.com/svanharmelen/xtdr/vendor/github.com/quickfixgo/quickfix/initiator.go:38 +0xe0
==================
Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: github/fork/svanharmelen/b-data-race