Skip to content
GitLab
    • Explore Projects Groups Snippets
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • Q quickfix
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 48
    • Issues 48
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 25
    • Merge requests 25
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • quickfixgo
  • quickfix
  • Merge requests
  • !367
An error occurred while fetching the assigned milestone of the selected merge_request.

for xml charset and bug of "Incorrect NumInGroup"

  • Review changes

  • Download
  • Email patches
  • Plain diff
Closed gpmn requested to merge github/fork/gpmn/master into master 6 years ago
  • Overview 0
  • Commits 3
  • Pipelines 0
  • Changes 2

for "Incorrect NumInGroup" https://github.com/quickfixgo/quickfix/issues/366 https://github.com/quickfixgo/quickfix/issues/365

for xml charset: https://github.com/quickfixgo/quickfix/issues/363

Compare
  • master (base)

and
  • latest version
    dbd1cd31
    3 commits, 2 years ago

2 files
+ 7
- 5

    Preferences

    File browser
    Compare changes
datadic‎tionary‎
datadict‎ionary.go‎ +4 -0
valida‎tion.go‎ +3 -5
datadictionary/datadictionary.go
+ 4
- 0
  • View file @ dbd1cd31

  • Edit in single-file editor

  • Open in Web IDE


@@ -3,6 +3,7 @@ package datadictionary
import (
"encoding/xml"
"io"
"os"
)
@@ -326,6 +327,9 @@ func Parse(path string) (*DataDictionary, error) {
doc := new(XMLDoc)
decoder := xml.NewDecoder(xmlFile)
decoder.CharsetReader = func(encoding string, input io.Reader) (io.Reader, error) {
return input, nil
}
if err := decoder.Decode(doc); err != nil {
return nil, err
}
validation.go
+ 3
- 5
  • View file @ dbd1cd31

  • Edit in single-file editor

  • Open in Web IDE


@@ -10,15 +10,14 @@ type validator interface {
type validatorSettings struct {
CheckFieldsOutOfOrder bool
RejectInvalidMessage bool
RejectInvalidMessage bool
}
//Default configuration for message validation.
//See http://www.quickfixengine.org/quickfix/doc/html/configuration.html.
var defaultValidatorSettings = validatorSettings{
CheckFieldsOutOfOrder: true,
RejectInvalidMessage: true,
RejectInvalidMessage: true,
}
type fixValidator struct {
@@ -87,8 +86,6 @@ func validateFIX(d *datadictionary.DataDictionary, settings validatorSettings, m
}
}
return nil
}
@@ -215,6 +212,7 @@ func validateVisitGroupField(fieldDef *datadictionary.FieldDef, fieldStack []Tag
if childDefs[0].Required() {
return fieldStack, RequiredTagMissing(Tag(childDefs[0].Tag()))
}
fieldStack = fieldStack[1:]
}
childDefs = childDefs[1:]
0 Assignees
None
Assign to
0 Reviewers
None
Request review from
Labels
0
None
0
None
    Assign labels
  • Manage project labels

Milestone
No milestone
None
None
Time tracking
No estimate or time spent
Lock merge request
Unlocked
0
0 participants
Reference:
Source branch: github/fork/gpmn/master

Menu

Explore Projects Groups Snippets