Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • Q quickfix
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 48
    • Issues 48
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 25
    • Merge requests 25
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • quickfixgo
  • quickfix
  • Merge requests
  • !385

Tls server name config

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Administrator requested to merge github/fork/linmaosong2018/tls-server-name-config into master Nov 06, 2019
  • Overview 2
  • Commits 4
  • Pipelines 0
  • Changes 5

Created by: linmaosong2018

Fixes #384 (closed):

  • Support TLS SNI by passing in ServerName configuration
  • If -- InsecureSkipVerify is false -- ServerName not configured then copy the host part of the connection address as the ServerName. This essentially restores the behavior before https://github.com/quickfixgo/quickfix/commit/ce2275bf2c97f679d58b639e7b90d8b3e3e34b8b

Tests done:

  • Unit tests - passing
  • Manual test with the test code in #384 (closed) - passing
Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: github/fork/linmaosong2018/tls-server-name-config