Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • Q quickfix
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 48
    • Issues 48
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 25
    • Merge requests 25
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • quickfixgo
  • quickfix
  • Merge requests
  • !394

feat: Acceptor addr listener accessor

  • Review changes

  • Download
  • Email patches
  • Plain diff
Closed Administrator requested to merge github/fork/vbiret/feature/acceptor_listener_addr_accessor into master Jan 17, 2020
  • Overview 2
  • Commits 2
  • Pipelines 0
  • Changes 1

Created by: vbiret

As per https://github.com/quickfixgo/quickfix/issues/388

  • adds an accessor function in the Acceptor struct in order to return the net.Addr of the listener, we do not return the listener itself to avoid accessing other functions such as Close()

As per now Acceptor does not have a testing suite, hence no tests being added to this PR. Following Contributions guidelines it should still be fine, let me know if anything else is required/needed

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: github/fork/vbiret/feature/acceptor_listener_addr_accessor