Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • Q quickfix
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 48
    • Issues 48
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 25
    • Merge requests 25
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • quickfixgo
  • quickfix
  • Merge requests
  • !438

Component should never be a pointer

  • Review changes

  • Download
  • Email patches
  • Plain diff
Open Ruben de Vries requested to merge github/fork/prvbl/required-fields-from-components into main May 26, 2021
  • Overview 0
  • Commits 1
  • Pipelines 1
  • Changes 4

changed all usage of Component to always be on Component, never *Component, this way the type switches actually work everywhere and consistently.
Because both *Component and Component implement MessagePart it was being mixed up.

This fixes a bug in the generated code not considering required fields from required components to be required and thus they weren't added to the New() constructor for a message.

I think this could be considered a BC break ..., not sure how you guys deal with that?
If someone had a component with required fields which was marked as required then if they'd run generate-fix again the fields will be added to the arguments of New()...

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: github/fork/prvbl/required-fields-from-components