Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • M metaseq
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 95
    • Issues 95
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 41
    • Merge requests 41
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • Administrator
  • metaseq
  • Merge requests
  • !230

[Cleanup] Delete unused methods / imports / args: 1/N

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Administrator requested to merge susan/unused_things into main Jul 17, 2022
  • Overview 2
  • Commits 8
  • Pipelines 0
  • Changes 11

Created by: suchenzang

Following https://github.com/facebookresearch/metaseq/pull/229 and continuing to break down https://github.com/facebookresearch/metaseq/pull/197.

Remove:

  • unused handle_legacy_ln_ method
  • unused reorder_encoder_out method
  • unused net_outputs arg in get_targets
  • redundant load_state_dict method (previously needed to override given the added step of "upgrade state dict" to be backwards compatible)
  • unused Namespace import
  • unused sample arg from get_normalized_probs_scriptable and get_normalized_probs methods
Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: susan/unused_things