Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • M metaseq
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 95
    • Issues 95
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 41
    • Merge requests 41
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • Administrator
  • metaseq
  • Merge requests
  • !267

updated to ensure cat happens on CUDA

  • Review changes

  • Download
  • Email patches
  • Plain diff
Open Administrator requested to merge kchakrabarty/evalspeedup into main Jul 28, 2022
  • Overview 11
  • Commits 2
  • Pipelines 0
  • Changes 1

Created by: KUNAL1612

Patch Description Observed during evaluating some models that the torch.cat operation in L732 took up 11.98GB of CPU memory. Used debugger to confirm that this was indeed because all tensors in shards_to_load function was on CPU. Because of this CPU operation, model loading using this function was slower than it needed to be. This speeds that up.

Testing steps Observed memory traces generated using profiler. Made changes and saw that model loading time using this function dropped anywhere between 10-15% given the same baseline conditions.

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: kchakrabarty/evalspeedup