Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • M metaseq
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 95
    • Issues 95
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 41
    • Merge requests 41
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • Administrator
  • metaseq
  • Merge requests
  • !408

[inference] Allow non-gpt2 tokenizers in certain code paths.

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Administrator requested to merge bpeinf into main Oct 14, 2022
  • Overview 2
  • Commits 2
  • Pipelines 0
  • Changes 1

Created by: stephenroller

Patch Description While this is simply fixing code we plan to deprecate anyway, I think we need this.

Some of the code paths (namely the generation path for evals) uses this BPE config to instantiate tokenizers. Unfortunately, since this field is missing from the dataclass, it doesn't get populated so when we load up models over there, we can't tell that the tokenizer should be instantiated, and we end up with this hardcoded gpt2 tokenizer path.

This patch fixes that by allowing the tokenizer to load in this BPE class.

Testing steps Evaluating a model trained with a different tokenizer.

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: bpeinf