Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • M metaseq
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 95
    • Issues 95
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 41
    • Merge requests 41
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • Administrator
  • metaseq
  • Merge requests
  • !424

Fix bug in accounting for data loaders

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Administrator requested to merge github/fork/zdevito/bug into main Oct 16, 2022
  • Overview 2
  • Commits 1
  • Pipelines 0
  • Changes 1

Created by: zdevito

The worker in the dataloader tells its ID to the training process so that it can keep a count of how many sentences each worker has processed and which worker is next. However, worker IDs have to be rotated using worker_offset on restart. This offset was not added to the ID in this case.

TODO: make a test with a repro, which will require these steps

  • Train normally, and checkpoint at a step that is not divisible by num_workers
  • checkpoint
  • Resume and train for a number of steps that is not divisible by num_workers
  • checkpoint
  • Resume (old code will resume with the wrong worker)
Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: github/fork/zdevito/bug