Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • P pagerbot
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 16
    • Issues 16
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 2
    • Merge requests 2
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • Stripe Community Contributions
  • pagerbot
  • Merge requests
  • !64

Allow passing pd & slack secrets via env var

  • Review changes

  • Download
  • Email patches
  • Plain diff
Closed Dan Benamy requested to merge github/fork/dbenamy/master into master Aug 08, 2018
  • Overview 1
  • Commits 18
  • Pipelines 0
  • Changes 26

In some deployments there are existing mechanism for handling secrets which would be preferred to having them in the mongo db.

This also unifies 2 code paths for configuring PagerDuty.

Testing:

  • Automated tests pass
  • Original flow of storing these secrets in mongo works
  • Using env vars instead works (although the admin will incorrectly show an error for the slack token and I had to make any dummy edit to cause it to save the bot settings)
Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: github/fork/dbenamy/master