Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • P pagerbot
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 16
    • Issues 16
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 2
    • Merge requests 2
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • Stripe Community Contributions
  • pagerbot
  • Merge requests
  • !67

Upgrade to Ruby 2.5.1 Support, avoid seg faults from old activesupport package.

  • Review changes

  • Download
  • Email patches
  • Plain diff
Open Zack Whipkey requested to merge github/fork/ZeroCater/master into master Sep 16, 2018
  • Overview 5
  • Commits 1
  • Pipelines 1
  • Changes 5

I had issues deploying this on a heroku-18 stack with the version of ruby defined. Segfaults were occurring from a 4.0.3 activesupport dependency, supplied by the ruby package system when using the defined ruby versions (2.2? 2.3?).

This pull request upgrades everything to 2.5.1 ruby, including all of its dependencies.

Tests pass after rebuilding the dockerimage (updated to extend from RUBY:2.5)

Let me know if there's a better way of defining these version restrictions. It's possible it might work with 2.4 well, but I haven't had the time to try. The ruby buildpack does not support Ruby 2.3 running on the latest stack (heroku-18).

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: github/fork/ZeroCater/master