Skip to content
GitLab
  1. 07 Jan, 2013 2 commits
    • Fabien Potencier's avatar
      merged branch kosssi/bugfix/css-selector-empty (PR #6271) · 354d622b
      Fabien Potencier authored 
      This PR was squashed before being merged into the 2.0 branch (closes #6271).

Commits
-------

dbafc2c [CssSelector] added css selector with empty string

Discussion
----------

[CssSelector] added css selector with empty string

---------------------------------------------------------------------------

by kosssi at 2012-12-14T18:29:40Z

Bug fix: yes
Feature addition: no
Backwards compatibility break: no
Symfony2 tests pass: yes
License of the code: MIT

---------------------------------------------------------------------------

by stloyd at 2013-01-07T08:21:56Z

@fabpot ping

---------------------------------------------------------------------------

by fabpot at 2013-01-07T10:28:54Z

Sorry, but I don't understand the use case.

---------------------------------------------------------------------------

by kosssi at 2013-01-07T10:36:31Z

if you have this code :
    \<img src="..." alt="">

you can find
    $this->assertCount(1, $crawler->filter('img[alt=""]'));

---------------------------------------------------------------------------

by fabpot at 2013-01-07T10:40:12Z

Then, can you change the unit test with the real use case?

---------------------------------------------------------------------------

by kosssi at 2013-01-07T11:05:50Z

I don't know if it suits you

---------------------------------------------------------------------------

by fabpot at 2013-01-07T11:07:11Z

thanks
      354d622b
    • Simon Constans's avatar
      [CssSelector] added css selector with empty string · 8015aea4
      Simon Constans authored
      8015aea4
  3. 04 Jan, 2013 1 commit
  5. 11 Dec, 2012 1 commit
  7. 09 Jul, 2012 1 commit
  9. 20 May, 2012 1 commit
  11. 18 May, 2012 1 commit
  13. 16 May, 2012 1 commit
  15. 15 May, 2012 1 commit
  17. 13 May, 2012 2 commits
  19. 12 May, 2012 1 commit
  21. 11 Mar, 2012 1 commit
  23. 22 Feb, 2012 1 commit
  25. 05 Jan, 2012 1 commit
  27. 18 Dec, 2011 2 commits
    • Fabien Potencier's avatar
      tweaked the README files · fe80ca26
      Fabien Potencier authored
      fe80ca26
    • Fabien Potencier's avatar
      merged branch lsmith77/component_readmes (PR #2561) · 72804789
      Fabien Potencier authored 
      Commits
-------

1e370d7 typo fix
93d8d44 added some more infos about Config
27efd59 added READMEs for the bridges
34fc866 cosmetic tweaks
d6af3f1 fixed README for Console
6a72b8c added basic README files for all components

Discussion
----------

added basic README files for all components and bridges

heavily based on http://fabien.potencier.org/article/49/what-is-symfony2 and the official Symfony2 documentation

---------------------------------------------------------------------------

by jmikola at 2011/11/03 13:36:07 -0700

Great work. For syntax highlighting on the PHP snippets, you could add "php" after the three backticks.

---------------------------------------------------------------------------

by lsmith77 at 2011/11/03 13:41:29 -0700

done

---------------------------------------------------------------------------

by stealth35 at 2011/11/03 13:49:31 -0700

Nice job, but you also need to add `<?php`

ex :

``` php
<?php
use Symfony\Component\DomCrawler\Crawler;

$crawler = new Crawler();
$crawler->addContent('<html><body><p>Hello World!</p></body></html>');

print $crawler->filter('body > p')->text();
```

---------------------------------------------------------------------------

by lsmith77 at 2011/11/03 13:56:57 -0700

done

---------------------------------------------------------------------------

by ericclemmons at 2011/11/03 19:57:57 -0700

@lsmith77 Well done!  This makes consumption of individual components that much easier, *especially* now that `composer.json` files have been added.

---------------------------------------------------------------------------

by lsmith77 at 2011/11/04 01:18:23 -0700

ok .. fixed the issues you mentioned @fabpot

---------------------------------------------------------------------------

by lsmith77 at 2011/11/11 15:00:27 -0800

@fabpot anything else left? seems like an easy merge .. and imho there is considerable benefit for our efforts to spread the word about the components with this PR merged.

---------------------------------------------------------------------------

by drak at 2011/11/11 18:54:13 -0800

You know, it might be a nice idea to put a link to the documentation for each component if there is some at symfony.com

---------------------------------------------------------------------------

by lsmith77 at 2011/11/12 00:59:14 -0800

i did that in some. but i might have missed a few places.
On 12.11.2011, at 03:54, Drak <reply@reply.github.com> wrote:

> You know, it might be a nice idea to put a link to the documentation for each component if there is some at symfony.com
>
> ---
> Reply to this email directly or view it on GitHub:
> https://github.com/symfony/symfony/pull/2561#issuecomment-2715762

---------------------------------------------------------------------------

by breerly at 2011/11/21 10:28:36 -0800

Pretty excited with this.

---------------------------------------------------------------------------

by dbu at 2011/11/24 00:02:50 -0800

is there anything we can help with to make this ready to be merged?

---------------------------------------------------------------------------

by lsmith77 at 2011/12/18 02:39:23 -0800

@fabpot: seriously .. if you are not going to deliver something "better" and don't provide a reason what is wrong with this .. then its beyond frustrating. i obviously do not claim that these README's are perfect (and certainly still no replacement for proper documentation), but I do claim that in their current form they are a radical step forward to potential users of the Symfony2 components.
      72804789
  29. 13 Dec, 2011 1 commit
  31. 01 Dec, 2011 1 commit
    • Fabien Potencier's avatar
      merged branch pscheit/master (PR #2742) · 4b6e5e7f
      Fabien Potencier authored 
      Commits
-------

63e2a99 [CssSelector] Fixed Issue for XPathExprOr: missing prefix in string conversion

Discussion
----------

[CssSelector] Issue for XPathExprOr: missing prefix in string conversion

Hi there,

I created a small and dumb test for the issue. I looked at the original implementation and i think the problem is, that private properties are used in the parent class for xPathExprOr. so that the prefix cannot be accessd with $this->prefix in XPathExprOr
However I think the distribution for the prefix should be put in the parts of the or-sub-expressions the way it is shown in the test.

Hope this helps.

Best regards
Philipp
      4b6e5e7f
  33. 28 Nov, 2011 1 commit
  35. 17 Nov, 2011 1 commit
  37. 03 Nov, 2011 1 commit
  39. 02 Nov, 2011 2 commits
  41. 01 Nov, 2011 1 commit
  43. 26 Sep, 2011 1 commit
  45. 29 Jun, 2011 2 commits
  47. 15 Jun, 2011 1 commit
  49. 14 Jun, 2011 2 commits
  51. 23 Apr, 2011 1 commit
  53. 22 Apr, 2011 1 commit
  55. 15 Apr, 2011 1 commit
  57. 24 Mar, 2011 2 commits
  59. 06 Mar, 2011 1 commit
  61. 01 Mar, 2011 1 commit
  63. 27 Feb, 2011 2 commits