Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • A administrate
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 96
    • Issues 96
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 32
    • Merge requests 32
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • thoughtbot, inc.
  • administrate
  • Issues
  • #2244
Closed
Open
Issue created Aug 11, 2022 by Administrator@rootContributor

Some HTML elements have redundant ARIA roles

Created by: metamoni

  • What were you trying to do? I noticed that the header in the index view has a redundant role property. There are other header elements that have the same issue, as well as a main with a redundant role="main", a nav with role="navigation" and a th that has a role="columnheader".
<header class="main-content__header" role="banner">

While this doesn't cause any technical issues, it's bad practice and it encourages other developers to follow the same pattern.

A list of all implicit roles is available here: ARIA in HTML

  • What did you end up with (logs, or, even better, example apps are great!)? N/A

  • What versions are you running?

    • Rails: 7.0.2.3
    • administrate: 0.17.0
Assignee
Assign to
Time tracking