Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • A administrate
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 96
    • Issues 96
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 32
    • Merge requests 32
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • thoughtbot, inc.
  • administrate
  • Merge requests
  • !1004

Add and improve I18n for application templates

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Administrator requested to merge github/fork/buren/i18n into master Oct 16, 2017
  • Overview 8
  • Commits 3
  • Pipelines 0
  • Changes 25

Created by: buren

I finally got around replacing/updating #785, which adds better I18n support for administrate.


  • Removes "hardcoded" placement of resource name for edit/new/show links (problematic on Arabic and other right-to-left languages since the positioning of the name will be flipped too).
  • Update config/locale/administrate.en.yml
  • Includes the latest commit from master
  • Use display_resource_name consistently when calling page.resource_name in view templates
  • Update all other locale files
    • Any comments/suggestions on how I best should go about this?
    • If I use i18n-tasks add-missing other updates (formatting etc) are made in the locale files
    • Should we try to re-use the existing strings or do we deem that dangerous and think its better that translations are re-done by someone who actually understands the language? 😅

⚠️ There is one expected test failure for rspec ./spec/i18n_spec.rb:9 # I18n does not have missing keys (see TODO)

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: github/fork/buren/i18n