Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • A administrate
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 96
    • Issues 96
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 32
    • Merge requests 32
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • thoughtbot, inc.
  • administrate
  • Merge requests
  • !1028

Fix has one class name

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Administrator requested to merge github/fork/dmitry-solomadin/ds-fix-has-one-class-name into master Nov 20, 2017
  • Overview 34
  • Commits 7
  • Pipelines 0
  • Changes 29

Created by: dmitry-solomadin

Related issue: https://github.com/thoughtbot/administrate/issues/951

Currently, when passing class_name option to has_one field it does not infer correct class name for the dashboard which results in exception. This PR modifies has_one class to use associative to get the correct dashboard name. Additionally, it fixes permitted_attributes method, which required me to modify the signature and pass options from Deferred attribute.

In scope of this I've also removed old locale keys for has_one.not_supported string.

/r @nickcharlton @tysongach

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: github/fork/dmitry-solomadin/ds-fix-has-one-class-name