Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • A administrate
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 96
    • Issues 96
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 32
    • Merge requests 32
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • thoughtbot, inc.
  • administrate
  • Merge requests
  • !108

Add comments to page views and field partials

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Administrator requested to merge view-comments into master Oct 23, 2015
  • Overview 1
  • Commits 1
  • Pipelines 0
  • Changes 42

Created by: gracewashere

https://trello.com/c/2Pan7Jmp

Problem:

When a developer generates a template in order to override it, it is not always clear which local and instance variables are available for them to use.

In order to get a good idea of what's going on, they would need to open up Administrate's source code, take a look at the controller, and see which variables are being assigned for the view to use.

Solution:

Add comments at the top of each view detailing which variables are in scope, with links to further documentation about the variables.

Review checklist:

  • verify all rubydoc links are correct
  • verify comment titles (e.g. "Email Show Partial") matches up with filename
  • Replace TODO with links to selectize and datetimepicker
  • replace "contains methods for accessing the underlying attribute data"
Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: view-comments