Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • A administrate
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 96
    • Issues 96
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 32
    • Merge requests 32
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • thoughtbot, inc.
  • administrate
  • Merge requests
  • !1150

There's a spec that requires consistent ordering here

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Pablo Brasero requested to merge pbm-ensure-consistent-order into master Apr 20, 2018
  • Overview 1
  • Commits 2
  • Pipelines 0
  • Changes 2

https://github.com/thoughtbot/administrate/issues/1114 points out that spec/features/show_page_spec.rb:28 may fail randomly (rarely, but it can). This is probably because the spec navigates a paginated list, but we are not specifying an order for this list.

This should fix the problem... if that is indeed the issue here. We can revisit if we see this failing randomly again.

Additionally, I rephrased that spec's description, to something that sounded a bit better to me.

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: pbm-ensure-consistent-order