Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • A administrate
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 96
    • Issues 96
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 32
    • Merge requests 32
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • thoughtbot, inc.
  • administrate
  • Merge requests
  • !1151

Don't show navigation items if the user can't view the collection anyway

  • Review changes

  • Download
  • Email patches
  • Plain diff
Closed Administrator requested to merge github/fork/jmmastey/dont-show-unindexable-models into master Apr 21, 2018
  • Overview 2
  • Commits 1
  • Pipelines 0
  • Changes 2

Created by: jmmastey

Per discussion on #1111 (closed), removes items from the left navigation if you aren't allowed the index? action on them.

I'm not 100% happy with the test for this, but this didn't fit well with the feature specs that were already in the app and I didn't want to drag a huge change into a small feature. Let me know if they still need work (and a hint of what you'd prefer would be appreciated).

Thanks!

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: github/fork/jmmastey/dont-show-unindexable-models