Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • A administrate
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 96
    • Issues 96
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 32
    • Merge requests 32
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • thoughtbot, inc.
  • administrate
  • Merge requests
  • !1161

Allow parameters that are more permissive

  • Review changes

  • Download
  • Email patches
  • Plain diff
Open Eric Collins requested to merge more-permissive-params into main May 04, 2018
  • Overview 4
  • Commits 2
  • Pipelines 0
  • Changes 2

When using the Clearance gem's backdoor to access views in administrate, tests prematurely break because of the as parameter used to do quick sign in. While it's probably fair that we don't want persist that parameter through the GET request, it shouldn't matter what parameters we pass in a GET request.

  • Use permit! to allow anything through on a GET request
Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: more-permissive-params