Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • A administrate
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 96
    • Issues 96
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 32
    • Merge requests 32
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • thoughtbot, inc.
  • administrate
  • Merge requests
  • !1290

Fix dashboard generator for attributes that are neither reflections nor columns

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Administrator requested to merge github/fork/s-mage/master into master Feb 23, 2019
  • Overview 7
  • Commits 1
  • Pipelines 0
  • Changes 2

Created by: s-mage

Rails allow to define custom attribute. It's usually used for coersion but nothing prevents me to use it as attr_accessor. For such cases generator was failing with undefined method 'has_one?' for nil:NilClass (NoMethodError)

With this fix generator doesn't try to define what's that and relies on column names instead of attribute names.

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: github/fork/s-mage/master