Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • A administrate
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 96
    • Issues 96
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 32
    • Merge requests 32
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • thoughtbot, inc.
  • administrate
  • Merge requests
  • !1336

Test against Rails 6.0.0rc1

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Daniel Colson requested to merge rails6 into master Apr 28, 2019
  • Overview 15
  • Commits 2
  • Pipelines 0
  • Changes 12

To get ready for Rails 6.0.0 we can start testing against 6.0.0.rc1

Rails 6.0.0 has some breaking changes that don't allow it to work with older versions of rspec-rails, so we will need to use rspec-rails 4.0. rspec-rails 4.0 is not compatible with older versions of rails.

I also removed the pessimistic version constraints for the Rails libraries in the gemspec. These constraints make it harder for people to upgrade, and it is something Rails itself is moving away from.

The tests are passing on Ruby 2.6. On the Ruby 2.5 build bundler doesn't seem to be able to resolve the dependencies. I will try gem "railties", "~> 6.0.0.rc1" in the Appraisal file instead of loading each library separately to see if that gets what we need. Edit: the build is now passing for Ruby 2.5 as well.

Rails 6 is not compatible with Ruby 2.4 so we will need to either stop running against Ruby 2.4 altogether, or find something similar to Travis's exclude (see the factory_bot_rails travis setup) so we can skip running Rails 6 with Ruby 2.4. I am still not all that comfortable with circleci config, so this might take me some time. Updating to circleci 2.1 and using commands seems to have done the trick.

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: rails6