Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • A administrate
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 96
    • Issues 96
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 32
    • Merge requests 32
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • thoughtbot, inc.
  • administrate
  • Merge requests
  • !1484

Double-click to select attribute text

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Administrator requested to merge github/fork/croaky/croaky/div into master Dec 09, 2019
  • Overview 6
  • Commits 2
  • Pipelines 0
  • Changes 2

Created by: croaky

Each show page displays a description list of the fields. When the field is text, it is rendered inside an inline <span>.

I've found it common to want to double-click this text to copy-paste an identifier from our admin app into other systems.

Previously, double-clicking would not select the field's value. The bug can be seen on the show page in the demo app. For example, try selecting the city or zip code values from:

https://administrate-prototype.herokuapp.com/admin/orders/198962

Changing the markup to be a block <div> fixes the bug. Alternatively, we could change the preserve-whitespace CSS rule to be display: block;.

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: github/fork/croaky/croaky/div