Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • A administrate
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 96
    • Issues 96
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 32
    • Merge requests 32
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • thoughtbot, inc.
  • administrate
  • Merge requests
  • !1557

More natural tabbing across rows in table

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Pablo Brasero requested to merge github/fork/pablobm/collection-tabindex into master Feb 20, 2020
  • Overview 0
  • Commits 1
  • Pipelines 0
  • Changes 2

(This PR is a split from https://github.com/thoughtbot/administrate/pull/1494, which was mixing two different concerns.)

When the user presses tab, the browser is expected to move to the next link. Since all cells in the table are links, the user has to press tab many times (once per column) in order to move to the next row:

Tab stopping at each single cell

Since each row works as a link, so much tabbing should not be necessary. This change makes it so that each row is tabbable, but not the cells.

There are two exceptions: action links, and data that should actually be represented as a link (eg: instances of Field::Url or Field::Email). These are not affected by this change, and are still accessible with an additional tab press for each cell. The row will be highlighted first, then each data link:

Tab stopping at whole rows, and specific link cells

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: github/fork/pablobm/collection-tabindex