Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • A administrate
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 96
    • Issues 96
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 32
    • Merge requests 32
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • thoughtbot, inc.
  • administrate
  • Merge requests
  • !1649

Use singular resource name for error explanation

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Administrator requested to merge github/fork/efatsi/singular-errors into master May 14, 2020
  • Overview 2
  • Commits 1
  • Pipelines 0
  • Changes 2

Created by: efatsi

Just a little thing I noticed.

Was: Screen Shot 2020-05-14 at 11 40 06 AM

Now: Screen Shot 2020-05-14 at 11 43 17 AM


Not sure if this is too much of a bandaid approach here. Was imagining potentially passing in the count option to display_resource_name from the error partial view code, but if you haven't defined a translation, then the default string that's constructed is what ends up being returned. Given that the default comes from default_resource_name (which pluralizes the model name), the count is often ignored for the plural version.

Thoughts on if this is good enough or if a larger refactor around how display_resource_name is used is called for?

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: github/fork/efatsi/singular-errors