Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • A administrate
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 96
    • Issues 96
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 32
    • Merge requests 32
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • thoughtbot, inc.
  • administrate
  • Merge requests
  • !1690

Restore destroy functionality

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Nick Charlton requested to merge nc-restore-destroy into master Jun 26, 2020
  • Overview 2
  • Commits 1
  • Pipelines 0
  • Changes 5

In #1618, we removed the explicit include of jquery_ujs as it should no longer be necessary. Alas, this broke the ability to destroy items.

This wasn't caught by the tests because Capybara tries to be clever with these links, sending the DELETE directly instead of clicking on the link. We disable this here and switch the specs to use the JS driver so that we're actually testing the functionality (it can't pass without).

Adding the include of jquery_ujs solves this for now, unblocking us from having a release for lots of other features and allows us to revisit this problem again (in a way that we'll catch it this time!).

Fixes #1643 (closed).

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: nc-restore-destroy