Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • A administrate
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 96
    • Issues 96
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 32
    • Merge requests 32
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • thoughtbot, inc.
  • administrate
  • Merge requests
  • !1777

ko: Model name label on the Index page now translated by i18n

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Administrator requested to merge github/fork/KOlofinmoyin/ko_index_page_not_using_i18n into master Sep 21, 2020
  • Overview 18
  • Commits 1
  • Pipelines 0
  • Changes 6

Created by: KOlofinmoyin

Currently, the label of the "New resource" button is not being translated.

image

The natural way to translate this is probably to rely on display_resource_name. However this always displays the plural form of the name. In this PR we modify this method to accept an option to display the singular form where requested. Additionally, we introduce the gem kaminary-i18n in the example app. If missing, Kaminari will be missing translations e.g. 'Next' and 'Last' buttons, and will break if we run the app in a different language. Visual testing of this PR requires this gem, so we consider it should be part of the change.

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: github/fork/KOlofinmoyin/ko_index_page_not_using_i18n