Created by: jmeinerz
We were assuming that all fields were required when a presence validation existed. While that makes sense, it's also possible for validations to be conditional.
Take the following validation as an example:
validates :phone_number, presence: true, if: :egyptian?Before this commit, the UI would flag phone_number as required, even for records who were not egyptian.
We now always flag these fields as optional. This is a bit misleading too, but it's impossible to know these things when the page is rendered, and marking them as optional makes for a slightly better user interface, as the user will most likely be prompted with detailed validation errors after trying to persist an invalid item, rather than be led to fill some fields that are, in fact, not mandatory.