Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • A administrate
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 96
    • Issues 96
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 32
    • Merge requests 32
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • thoughtbot, inc.
  • administrate
  • Merge requests
  • !193

Assume unknown db column types are un-searchable

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Administrator requested to merge gw-default-field into master Nov 08, 2015
  • Overview 2
  • Commits 1
  • Pipelines 0
  • Changes 5

Created by: gracewashere

Closes #178 (closed)

Problem:

If users have a database set up with unknown column types, Administrate treats those columns as a string. This can cause bugs when users try to search, because the unknown database column might not support the string search operator.

Solution:

  • Add a searchable option to all field types, which specifies whether it is one of the resource's plaintext search fields.
  • For unknown db column types, give the field a default option of searchable: false.
Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: gw-default-field