Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • A administrate
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 96
    • Issues 96
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 32
    • Merge requests 32
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • thoughtbot, inc.
  • administrate
  • Merge requests
  • !2182

Change ApplicationController's routes's class to Set to speed up "valid_action?"

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Administrator requested to merge github/fork/Shell-Wataru/main into main Apr 20, 2022
  • Overview 2
  • Commits 1
  • Pipelines 0
  • Changes 1

Created by: Shell-Wataru

I changed ApplicationController's routes's class to Set to speed up valid_action?.

Let N be number of routes. valid_action? checks all routes in current version. So the time complexity is O(N) . When we store routes as Set, the time complexity is O(log N) .

My application has hundreds of routes. valid_action? took a long time.

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: github/fork/Shell-Wataru/main