Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • A administrate
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 96
    • Issues 96
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 32
    • Merge requests 32
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • thoughtbot, inc.
  • administrate
  • Merge requests
  • !2238

Pass associated_class to collection from show

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Administrator requested to merge github/fork/stormmaster42/fix_i18n_collection_for_association_using_wrong_resource into main Aug 08, 2022
  • Overview 4
  • Commits 1
  • Pipelines 0
  • Changes 1

Created by: stormmaster42

This fixes an issue where the embedded collection is using the parent's class to define i18n headers.

Example: Ressource order has_many order_items. Order dashboard declares order_items: Field::HasMany

When the show which includes the order_items association is rendered within the collection partial it uses the parent's resource (Order) instead of OrderItem to determine the header label default.

Not sure how to add a test for this behavior.

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: github/fork/stormmaster42/fix_i18n_collection_for_association_using_wrong_resource