Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • A administrate
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 96
    • Issues 96
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 32
    • Merge requests 32
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • thoughtbot, inc.
  • administrate
  • Merge requests
  • !2324

Update to Rails 7

  • Review changes

  • Download
  • Email patches
  • Plain diff
Open Pablo Brasero requested to merge github/fork/pablobm/rails70 into main Jan 27, 2023
  • Overview 6
  • Commits 3
  • Pipelines 1
  • Changes 5

Administrate was already compatible with Rails 7, but its specs weren't. After doing some fixes, there's a pending one that appears to be caused by strange Ruby behaviour when undefining constants on Ruby 3.x.

Specifically, spec/generators/dashboard_generator_spec.rb creates a number of classes and then attempts to undefine them, but these appear to linger around, affecting results at spec/generators/routes_generator_spec.rb.

I have tried a few things to no avail. In some attempts I could fix this issue, but new ones would appear.

From what I can tell, this affects the specs, but not real world usage.

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: github/fork/pablobm/rails70