Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • A administrate
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 96
    • Issues 96
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 32
    • Merge requests 32
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • thoughtbot, inc.
  • administrate
  • Merge requests
  • !301

Update Nokogiri to v 1.6.7

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Administrator requested to merge gw-nokogiri into master Dec 07, 2015
  • Overview 0
  • Commits 1
  • Pipelines 0
  • Changes 3

Created by: gracewashere

Problem:

Our app doesn't directly depend on nokogiri - the test suite depends on Capybara, which in turn depends on Nokogiri.

Because of this, we should not have nokogiri referenced explicitly in our Gemfile.

Commit 12e0db49 upgraded nokogiri by explicitly setting the desired version in the Gemfile.

Solution:

Several PRs (#285, #293) have used a different approach for upgrading Nokogiri, in order to get their build passing.

They ran bundle update nokogiri without explicitly setting the desired version in the Gemfile. The most recent version of nokogiri contains the required security fix, so it solves the original problem.

This commit reverts the changes made in 12e0db49, and updates nokogiri using the standard bundle update nokogiri approach.

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: gw-nokogiri