Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • A administrate
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 96
    • Issues 96
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 32
    • Merge requests 32
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • thoughtbot, inc.
  • administrate
  • Merge requests
  • !339

Don't hard-code Administrate's URL namespace

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Administrator requested to merge gw-namespaces into master Dec 15, 2015
  • Overview 3
  • Commits 1
  • Pipelines 0
  • Changes 22

Created by: gracewashere

Closes #281 (closed) Related to #330, #332.

Problem:

Administrate requires that its dashboards be mounted at /admin.

In applications with an Admin model, Administrate will cause an error because it will try to define Admin as a module when it's already been defined as a class.

The hard-coded namespace limits users' freedom in defining their own URL schema, and prevents users from mounting multiple Administrate dashboards at once.

Solution:

Dynamically evaluate Administrate's namespace from the request's URL. This dynamically calculated value is used for all links and redirects in Administrate dashboards.

The namespace is now only set by generators. If a user wants to change their namespace away from the default of admin, they must run the generators and manually change admin to the namespace of their choice.

Next Steps:

Change generators to accept (or read from some configuration file) an optional namespace argument instead of always using the admin namespace.

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: gw-namespaces