Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • A administrate
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 96
    • Issues 96
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 32
    • Merge requests 32
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • thoughtbot, inc.
  • administrate
  • Merge requests
  • !368

Fix sidebar__link:last-child

  • Review changes

  • Download
  • Email patches
  • Plain diff
Closed Administrator requested to merge github/fork/rubenmoya/master into master Dec 29, 2015
  • Overview 2
  • Commits 2
  • Pipelines 0
  • Changes 2

Created by: rubenmoya

Hi all!

The &:last-child in the sidebar__link wasn't working properly since the link is inside an li so it's always the last item and the padding was always applied and the space between items was too big.

I solved it by adding a new class sidebar__item to the li and moving the :last-child to it. I also changed the paddings to margins, so you only can click the item when you press the link and not the space above it.

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: github/fork/rubenmoya/master