Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • A administrate
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 96
    • Issues 96
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 32
    • Merge requests 32
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • thoughtbot, inc.
  • administrate
  • Merge requests
  • !376

Started Rails 5 compatibility

  • Review changes

  • Download
  • Email patches
  • Plain diff
Closed Administrator requested to merge github/fork/hayesr/rails5_compat into master Jan 04, 2016
  • Overview 22
  • Commits 1
  • Pipelines 0
  • Changes 13

Created by: hayesr

Wanted to try Administrate in a new project I'm starting with the Rails 5 beta, so I dived in to see what it would take to make it work. This is probably not ready to merge since I had to jump through some hoops and pull in Github versions of gems to get tests working.

  • First error I ran into had to do with the column_types method. See this commit.
  • Next, using params in url generation is scary, and now throws an error. I like to live dangerously, and for now I just threw .permit! in there. This whole thing should probably be replaced by a helper method.
  • The initializer in the example app to disable XML parsers causes an error, but does not seem to be necessary.

Finally, I had to use master versions of Capybara and RSpec-* to get tests running. By including url_helpers in ActionView::TestCast::TestController I got tests to pass. I'm guessing this will be fixed, or there will be a more official way to do this in the future. Appraisals didn't pass, will Sass 3.4 be a concern after Rails 5?

I don't want to go much further without some feedback, but I'm happy to if it looks like I'm on the right path.

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: github/fork/hayesr/rails5_compat