Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • A administrate
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 96
    • Issues 96
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 32
    • Merge requests 32
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • thoughtbot, inc.
  • administrate
  • Merge requests
  • !389

Applies a margin-bottom to attribute labels

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Administrator requested to merge github/fork/naps62/mp-spacing into master Jan 08, 2016
  • Overview 6
  • Commits 2
  • Pipelines 0
  • Changes 1

Created by: naps62

P.S.: Even with the known issues I present below, I still prefer this over the current version, which is why I chose to propose this. No hard feelings if it doesn't go through 😄

Why:

  • When a nil attribute exists, the data element takes no height, which results in the row being too close to the next attribute.

This change addresses the need by:

  • The spacing between each attribute was previously given by the attribute-data field. But when it has no height, that margin gets swallowed by the label. Applying the same margin to it helps to fix this

Known issues:

  • $spacing-base is measured in ems. And since the label has a different font-size, this results in a slightly different margin, which will be noticeable in the same cases as in the original issue, but I guess a different margin is better than no margin.
  • When the label spans multiple lines, an even larger spacing gets created

Before: screenshot from 2016-01-08 10-46-17

After: screenshot from 2016-01-08 16-07-41

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: github/fork/naps62/mp-spacing