Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • A administrate
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 96
    • Issues 96
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 32
    • Merge requests 32
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • thoughtbot, inc.
  • administrate
  • Merge requests
  • !44

Add `Administrate::Page` and adhere to directory naming conventions

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Administrator requested to merge jro-page-module into master Jun 26, 2015
  • Overview 2
  • Commits 1
  • Pipelines 0
  • Changes 10

Created by: jayroh

When running the engine against a demo app I received an error stating the following: uninitialized constant Administrate::Page. Looking through the source I noticed that there was no explicit definition of that module. This commit adds that file and defines Administrate::Page explicitly.

Through the process of adding that file and module I also noticed that the directory structure containing all classes related to pages were placed under administrate/pages but were defined as Administrate::Page. The convention for structuring ruby libraries is to match modules with their directory structures and vice versa. This commit also makes that update to follow said conventions.

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: jro-page-module